[gwt-contrib] - Use z-index to layer multiple notifications in hosted.html (issue1323801)

Tue, 25 Jan 2011 10:12:03 -0800 

Reviewers: knorton,

Description:
- Use z-index to layer multiple notifications in hosted.html
- ModuleSpace.java produces well formed HTML, replacing </pre> with
</div>


Please review this at http://gwt-code-reviews.appspot.com/1323801/show

Affected files:
  M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
  M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
  M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java


Index: dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
===================================================================
--- dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (revision 9607) +++ dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (working copy) 
@@ -111,6 +111,9 @@
       + 'REFRESH</a> this page.');
 }

+// Keep track of z-index to allow layering of multiple glass messages
+var __gwt_glassMessageZIndex = 2147483647;
+
 // Note this method is also used by ModuleSpace.java
 function __gwt_displayGlassMessage(summary, details) {
   var topWin = window.top;
@@ -118,11 +121,13 @@
   var outer = topDoc.createElement("div");
   // Do not insert whitespace or outer.firstChild will get a text node.
   outer.innerHTML =
- '<div style="position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#000000;"></div>' + - '<div style="position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FFFFFF;font-family:verdana;">' + - '<div style="font-size:30px;font-weight:bold;">' + summary + '</div>' + 
-      '<p style="font-size:15px;">' + details + '</p>' +
-    '</div>'
+    '<div style="position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+    ';left:50px;top:50px;width:600px;color:#FFF;font-family:verdana;">' +
+    '<div style="font-size:30px;font-weight:bold;">' + summary + '</div>' +
+    '<div style="font-size:15px;">' + details + '</div>' +
+    '</div>' +
+    '<div style="position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+    
';left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=60);opacity:0.6;background-color:#000;"></div>'
   ;
   topDoc.body.appendChild(outer);
   var glass = outer.firstChild;
@@ -164,6 +169,10 @@
 //should be prefixed with "__gwt_"
 function fireOnModuleLoadStart(className) {
   $sendStats("moduleStartup", "onModuleLoadStart");
+var __gwt_glassMessageZIndex = 2147483647;
+
+var __gwt_glassMessageZIndex = 2147483647;
+
 }


Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===================================================================
--- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (revision 9607) +++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (working copy) 
@@ -164,6 +164,9 @@
       + 'REFRESH</a> this page.');
 }

+// Keep track of z-index to allow layering of multiple glass messages
+var __gwt_glassMessageZIndex = 2147483647;
+
 // Note this method is also used by ModuleSpace.java
 function __gwt_displayGlassMessage(summary, details) {
   var topWin = window.top;
@@ -171,11 +174,13 @@
   var outer = topDoc.createElement("div");
   // Do not insert whitespace or outer.firstChild will get a text node.
   outer.innerHTML =
- '<div style="position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#000000;"></div>' + - '<div style="position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FFFFFF;font-family:verdana;">' + - '<div style="font-size:30px;font-weight:bold;">' + summary + '</div>' + 
-      '<p style="font-size:15px;">' + details + '</p>' +
-    '</div>'
+    '<div style="position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+    ';left:50px;top:50px;width:600px;color:#FFF;font-family:verdana;">' +
+    '<div style="font-size:30px;font-weight:bold;">' + summary + '</div>' +
+    '<div style="font-size:15px;">' + details + '</div>' +
+    '</div>' +
+    '<div style="position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+    
';left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=60);opacity:0.6;background-color:#000;"></div>'
   ;
   topDoc.body.appendChild(outer);
   var glass = outer.firstChild;
Index: dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
===================================================================
--- dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java      (revision 9607)
+++ dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java      (working copy)
@@ -611,7 +611,7 @@
     String details = "<p>Exception while loading module <b>"
+ entryPointTypeName + "</b>. See Development Mode for details.</p>" 
         + "<div style='overflow:visisble;white-space:pre;'>" + stackTrace
-        + "</pre>";
+        + "</div>";

     invokeNativeVoid("__gwt_displayGlassMessage", null,
         new Class[]{String.class, String.class},


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to