http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005
File user/src/com/google/gwt/autobean/rebind/model/JBeanMethod.java
(right):

http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005#newcode30
user/src/com/google/gwt/autobean/rebind/model/JBeanMethod.java:30:
public enum JBeanMethod {
On 2011/01/25 18:09:38, rjrjr wrote:
Might as well make constants for IS, HAS and GET

Done.

http://gwt-code-reviews.appspot.com/1320801/diff/3001/4024
File
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java
(right):

http://gwt-code-reviews.appspot.com/1320801/diff/3001/4024#newcode74
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java:74:
Class<?> domainType, String property) {
On 2011/01/25 18:09:38, rjrjr wrote:
Should we check for redundant methods? (is or has or get, oh my)? Or
perhaps the
java bean spec has precedence defined?

What a stupid, stupid convention this is.

I updated RequestFactoryModel to disallow redundant property accessors
boolean getFoo() and boolean isFoo().  We can figure out a more nuanced
solution if anyone complains.

http://gwt-code-reviews.appspot.com/1320801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to