Looking at it more closely, there are two parts. You're including javax/validation/validation-api-1.0.0.GA-sources.jar for the validation api, right? Seems like we tried that before and got push back. So, @Chandler, if this is not the right way to make these standard interfaces available to client code, what is?
The other two jars you describe as an interim step. How short an interim are we talking about? The answer has to be "before 2.3 is cut." On Fri, Jan 28, 2011 at 11:04 AM, Ray Ryan <[email protected]> wrote: > Wait, I'm not sure we can do that. Dave Chandler, is this the kind of thing > that upset the maven community last time around? > > > On Fri, Jan 28, 2011 at 10:55 AM, <[email protected]> wrote: > >> Reviewers: rjrjr, Nick Chalko, >> >> Description: >> Added missing validation jars to gwt-user.jar. Fixes Issue 5950. >> >> >> Please review this at http://gwt-code-reviews.appspot.com/1323803/show >> >> Affected files: >> M user/build.xml >> >> >> Index: user/build.xml >> =================================================================== >> --- user/build.xml (revision 9650) >> +++ user/build.xml (working copy) >> @@ -148,6 +148,12 @@ >> <zipfileset src="${gwt.tools.lib}/tomcat/servlet-api-2.5.jar" >> excludes="**/*.java"/> >> <zipfileset src="${gwt.tools.lib}/w3c/sac/sac-1.3.jar" /> >> <zipfileset src="${gwt.tools.lib}/w3c/flute/flute-1.3-gg1.jar" /> >> + <zipfileset >> src="${gwt.tools.lib}/javax/validation/validation-api-1.0.0.GA.jar" /> >> + <!-- The source is included so validation is available from client >> code --> >> + <zipfileset >> src="${gwt.tools.lib}/javax/validation/validation-api-1.0.0.GA-sources.jar" >> /> >> + <!-- Hibernate is included until we can provide the super source as >> an third party jar" --> >> + <zipfileset >> src="${gwt.tools.lib}/hibernate/validator/hibernate-validator-4.1.0.Final.jar" >> /> >> + <zipfileset >> src="${gwt.tools.lib}/hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar" >> /> >> </gwt.jar> >> </target> >> >> >> >> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
