Overall LGTM.
http://gwt-code-reviews.appspot.com/1336801/diff/1/2 File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java (right): http://gwt-code-reviews.appspot.com/1336801/diff/1/2#newcode84 dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:84: private static boolean fileTypeMatch(FilterFileType filterFileType, I like the move to enums. Can you move all of the methods which are essentially switch statements on the enums into instance methods on the enums? For example, for this method: enum FilterFileType { RESOURCE_FILES, JAVA_FILES { public booleam matches(String path) { return path.endsWith(".java"); } }, ... public boolean matches(String path) { return true; } } http://gwt-code-reviews.appspot.com/1336801/diff/1/2#newcode278 dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:278: switch (filterFileType) { Ditto above. http://gwt-code-reviews.appspot.com/1336801/diff/1/2#newcode464 dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:464: switch (filterFileType) { Ditto above. http://gwt-code-reviews.appspot.com/1336801/diff/1/2#newcode476 dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:476: switch (filterFileType) { Ditto above. http://gwt-code-reviews.appspot.com/1336801/diff/1/3 File dev/core/test/com/google/gwt/dev/resource/impl/DefaultFiltersTest.java (right): http://gwt-code-reviews.appspot.com/1336801/diff/1/3#newcode613 dev/core/test/com/google/gwt/dev/resource/impl/DefaultFiltersTest.java:613: private static boolean fileTypeMatch(FilterFileType filterFileType, Can't use the non-test versions of these? http://gwt-code-reviews.appspot.com/1336801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
