Reviewers: bobv,
Description:
Binary annotations never become TypeDeclarations, so this short-circuit
code is unnecessarily preventing us from fully processing annotation
types. This is bad, because it's perfectly legal to have a concrete
class implement an annotation type.
Please review this at http://gwt-code-reviews.appspot.com/1340801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
Index: dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
index
1557dc4270d638a856e50093f30a77b8aab1ef1d..2b5dba117393c807fb33a9640b37cd470ef488f9
100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
@@ -451,14 +451,6 @@ public class GenerateJavaAST {
* output JavaScript.
*/
public void processType(TypeDeclaration x) {
- if (x.binding.isAnnotationType()) {
- // Do not process completely. Use tryGet for binary-only
annotations
- currentClass = (JDeclaredType) typeMap.tryGet(x.binding);
- if (currentClass != null) {
- processHasAnnotations(currentClass, x.annotations);
- }
- return;
- }
currentClass = (JDeclaredType) typeMap.get(x.binding);
processHasAnnotations(currentClass, x.annotations);
try {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
