Revision: 9664
Author: [email protected]
Date: Tue Feb  1 16:12:57 2011
Log: Fully process annotation types.

Binary annotations never become TypeDeclarations, so this short-circuit code is unnecessarily preventing us from fully processing annotation types. This is bad, because it's perfectly legal to have a concrete class implement an annotation type.

http://gwt-code-reviews.appspot.com/1340801/show

Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=9664

Modified:
 /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java

=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java Mon Jan 31 11:16:33 2011 +++ /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java Tue Feb 1 16:12:57 2011
@@ -451,14 +451,6 @@
      * output JavaScript.
      */
     public void processType(TypeDeclaration x) {
-      if (x.binding.isAnnotationType()) {
- // Do not process completely. Use tryGet for binary-only annotations
-        currentClass = (JDeclaredType) typeMap.tryGet(x.binding);
-        if (currentClass != null) {
-          processHasAnnotations(currentClass, x.annotations);
-        }
-        return;
-      }
       currentClass = (JDeclaredType) typeMap.get(x.binding);
       processHasAnnotations(currentClass, x.annotations);
       try {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to