LGTM -- with some questions
I looked over the high-level (and scanned each file). It looks like in
some places you also changed the types of params (e.g. JsExpression ->
JsVisitable). Was that intended? All the removing of template params
and removing of @SuppressWarnings("unchecked") seem ok (but is there
some background as to why they were like that originally, and why it's
ok to remove them)?
On 2011/02/02 19:08:10, scottb wrote:
BTW: most of this is search-and-replace, so there's really no need to
do a
line-item review of everything. Just a general high-level check and
some spot
checks is probably fine.
http://gwt-code-reviews.appspot.com/1310805/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors