Reviewers: zundel, jbrosenberg, cromwellian,
Message:
Few things here:
1) A rethinking of how JsScope should work. Most notably, the
JsRootScope is a singleton with special serialization. I also
refactored bits and pieces of the JsScope hierarchy to get rid of fields
and code that don't make sense for particular subclasses. And I broke
serialization circular references (that pull in the whole world) by not
having scopes serialize their children.
2) I got JsProgram out of the business of federating literals and
singletons. This is much more like how the Java AST works now.
Please review this at http://gwt-code-reviews.appspot.com/1342801/show
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java
M dev/core/src/com/google/gwt/dev/javac/JsniCollector.java
M dev/core/src/com/google/gwt/dev/javac/JsniMethod.java
M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptLiterals.java
M dev/core/src/com/google/gwt/dev/js/JsInliner.java
M dev/core/src/com/google/gwt/dev/js/JsObfuscateNamer.java
M dev/core/src/com/google/gwt/dev/js/JsParser.java
M dev/core/src/com/google/gwt/dev/js/JsPrettyNamer.java
M dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java
M dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
M dev/core/src/com/google/gwt/dev/js/JsSymbolResolver.java
M dev/core/src/com/google/gwt/dev/js/JsVerboseNamer.java
M dev/core/src/com/google/gwt/dev/js/ast/JsBooleanLiteral.java
M dev/core/src/com/google/gwt/dev/js/ast/JsCatchScope.java
M dev/core/src/com/google/gwt/dev/js/ast/JsEmpty.java
M dev/core/src/com/google/gwt/dev/js/ast/JsFunction.java
M dev/core/src/com/google/gwt/dev/js/ast/JsNameRef.java
A dev/core/src/com/google/gwt/dev/js/ast/JsNestingScope.java
A dev/core/src/com/google/gwt/dev/js/ast/JsNormalScope.java
M dev/core/src/com/google/gwt/dev/js/ast/JsNullLiteral.java
M dev/core/src/com/google/gwt/dev/js/ast/JsNumberLiteral.java
M dev/core/src/com/google/gwt/dev/js/ast/JsProgram.java
A dev/core/src/com/google/gwt/dev/js/ast/JsRootName.java
M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java
M dev/core/src/com/google/gwt/dev/js/ast/JsScope.java
M dev/core/src/com/google/gwt/dev/js/ast/JsStringLiteral.java
M dev/core/src/com/google/gwt/dev/shell/Jsni.java
M dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
M
dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
