Reviewers: robertvawter,

Description:
Quick patch, in follow up to r9344, which replaces remaining uses of the
legacy 'compiler.emulatedStack' property,
with the corresponding 'compiler.stackMode'.

Fixes issues: 5692


Please review this at http://gwt-code-reviews.appspot.com/1338804/show

Affected files:
M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml
  M user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml
  M user/src/com/google/gwt/junit/JUnit.gwt.xml
  M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java


Index: samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml
===================================================================
--- samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml (revision 9666) +++ samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml (working copy)
@@ -32,7 +32,7 @@
   <set-property name="gwt.logging.simpleRemoteHandler" value="DISABLED" />

<!-- Uncomment if you are enabling server side deobfuscation of StackTraces
-  <set-property name="compiler.emulatedStack" value="true" />
+  <set-property name="compiler.stackMode" value="emulated" />
<set-configuration-property name="compiler.emulatedStack.recordLineNumbers" value="true" /> <set-configuration-property name="compiler.emulatedStack.recordFileNames" value="true" />
   -->
Index: user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml
===================================================================
--- user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml       (revision 9666)
+++ user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml       (working copy)
@@ -26,7 +26,7 @@

   <!-- We do not want stack traces. -->
<set-configuration-property name="compiler.emulatedStack.recordFileNames" value="false" />
-  <set-property name="compiler.emulatedStack" value="false" />
+  <set-property name="compiler.stackMode" value="native" />

<generate-with class="com.google.gwt.benchmarks.rebind.BenchmarkGenerator"> <when-type-assignable class="com.google.gwt.benchmarks.client.Benchmark"/>
Index: user/src/com/google/gwt/junit/JUnit.gwt.xml
===================================================================
--- user/src/com/google/gwt/junit/JUnit.gwt.xml (revision 9666)
+++ user/src/com/google/gwt/junit/JUnit.gwt.xml (working copy)
@@ -33,7 +33,7 @@

   <!-- We want to provide consistent stack traces across all browsers. -->
<set-configuration-property name="compiler.emulatedStack.recordFileNames" value="true" />
-  <set-property name="compiler.emulatedStack" value="true" />
+  <set-property name="compiler.stackMode" value="emulated" />

<!-- Override the regular symbolMaps linker to put the data somewhere we can find it --> <define-linker name="symbolMaps" class="com.google.gwt.junit.linker.JUnitSymbolMapsLinker" />
Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===================================================================
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (revision 9666) +++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (working copy)
@@ -31,7 +31,7 @@
 /**
* Deobfuscates stack traces on the server side. This class requires that you
  * have turned on emulated stack traces, via
- * <code>&lt;set-property name="compiler.emulatedStack" value="true" /&gt;</code> + * <code>&lt;set-property name="compiler.stackMode" value="emulated" /&gt;</code> * in your <code>.gwt.xml</code> module file, and moved your symbol map files to * a location accessible by your server sever side code. You can use the GWT * compiler <code>-deploy</code> command line argument to specify the location


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to