For some reason, the 'View' link for TypeSerializerCreator is broken on this review (but I could look at the diff view).
http://gwt-code-reviews.appspot.com/1310807/diff/1/2 File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java (right): http://gwt-code-reviews.appspot.com/1310807/diff/1/2#newcode39 user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:39: private static final int INITIAL_CAPACITY = 16; Should be 'LOAD_FACTOR' http://gwt-code-reviews.appspot.com/1310807/diff/1/2#newcode58 user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:58: There are 2 getField() methods, one returns the Field itself, the other returns the Object value of the field. Can we differentiate the names of these 2? Perhaps have: getField & getFieldValue (and also change setField to setFieldValue). http://gwt-code-reviews.appspot.com/1310807/diff/1/3 File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right): http://gwt-code-reviews.appspot.com/1310807/diff/1/3#newcode44 user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java:44: /** Can you add some comments explaining the reason for, and the differences between, the prod and dev mode paths? http://gwt-code-reviews.appspot.com/1310807/diff/1/5 File user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java (right): http://gwt-code-reviews.appspot.com/1310807/diff/1/5#newcode20 user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:20: /** I assume that this will get optimized out, and not remain as part of an optimized web-mode compile (perhaps add that notion to the comment). http://gwt-code-reviews.appspot.com/1310807/diff/1/5#newcode26 user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:26: Rename this (if it's also to be renamed in the non super source version (e.g. getFieldValue()) http://gwt-code-reviews.appspot.com/1310807/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
