Gracias!

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004
File dev/core/src/com/google/gwt/core/ext/soyc/Member.java (left):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004#oldcode44
dev/core/src/com/google/gwt/core/ext/soyc/Member.java:44:
I have no idea... I just know that no code was ever calling this.  To be
honest, Bob & I had a long conversation and a lot of the original design
constraints no longer hold.  There's this entire glue layer whose sole
purpose was really to export data from the Compile phase to the Link
phase, where the SoycLinker would do its thing.  However... to allow
better sharding, SoycLinker does almost nothing these days, all the real
processing happens during permutation compile, so that it can be
sharded.  So there's this whole layer of DTO/glue stuff that, ideally,
could just die.

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2019
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(left):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2019#oldcode963
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:963:
SourceInfo sourceInfo = program.createSourceInfoSynthetic(
True, but at the moment it was just being thrown in the bit bucket, the
data didn't go anywhere.  I figure that as the needs of the output
report and data evolve, we can come back in here and judiciously add
what we need.

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2024
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right):

http://gwt-code-reviews.appspot.com/1345801/diff/2001/2024#newcode588
dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java:588: // and line
number.
Yeah, I talked to Toby about it, and I don't think there's anything
that's guaranteed to be fast on every VM.  However, in the Sun VM there
are some private methods on Throwable that allow you to grab a single
stack frame, which might work awesomely.  Maybe we should look around
and see if other VMs implement them.

http://gwt-code-reviews.appspot.com/1345801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to