LGTM

On Mon, Feb 14, 2011 at 8:34 AM, <rchan...@google.com> wrote:

> Reviewers: rjrjr, Nick Chalko,
>
> Description:
> Added validation jars to 'devmode' and 'test.dev' targets in ant
> webAppCreator templates
> Fixes Issue 5950.
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1352807/show
>
> Affected files:
>  M user/src/com/google/gwt/user/tools/project.ant.xmlsrc
>
>
> Index: user/src/com/google/gwt/user/tools/project.ant.xmlsrc
> ===================================================================
> --- user/src/com/google/gwt/user/tools/project.ant.xmlsrc       (revision
> 9731)
> +++ user/src/com/google/gwt/user/tools/project.ant.xmlsrc       (working
> copy)
> @@ -57,6 +57,8 @@
>       <classpath>
>         <pathelement location="@srcFolder"/>
>         <path refid="project.class.path"/>
> +        <pathelement location="@gwtValidationPath" />
> +        <pathelement location="@gwtValidationSourcesPath" />
>       </classpath>
>       <jvmarg value="-Xmx256M"/>
>       <arg value="-startupUrl"/>
> @@ -89,6 +91,8 @@
>         <pathelement location="@srcFolder" />
>         <pathelement location="@testFolder" />
>         <path refid="project.class.path" />
> +        <pathelement location="@gwtValidationPath" />
> +        <pathelement location="@gwtValidationSourcesPath" />
>         <pathelement location="@junitJar" />
>       </classpath>
>       <batchtest todir="reports/htmlunit.dev" >
> @@ -111,6 +115,8 @@
>         <pathelement location="@srcFolder" />
>         <pathelement location="@testFolder" />
>         <path refid="project.class.path" />
> +        <pathelement location="@gwtValidationPath" />
> +        <pathelement location="@gwtValidationSourcesPath" />
>         <pathelement location="@junitJar" />
>       </classpath>
>       <batchtest todir="reports/htmlunit.prod" >
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to