LGTM
http://gwt-code-reviews.appspot.com/1355804/diff/1/3 File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/3#newcode432 user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:432: public static void decodeInto(Splittable data, AutoBean<?> bean) { Yaaaaaay! http://gwt-code-reviews.appspot.com/1355804/diff/1/4 File user/src/com/google/gwt/autobean/shared/ValueCodex.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/4#newcode91 user/src/com/google/gwt/autobean/shared/ValueCodex.java:91: public Date decode(Class<?> clazz, String value) { format http://gwt-code-reviews.appspot.com/1355804/diff/1/4#newcode95 user/src/com/google/gwt/autobean/shared/ValueCodex.java:95: // XXX Figure out how to decode iso 8601 dates in compatible manner Is that really possible? Should we just declare this as a limitation of the framework, that dates are longs and such is life? Or is iso 8601 part of the json rpc "spec"? http://gwt-code-reviews.appspot.com/1355804/diff/1/7 File user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/7#newcode351 user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java:351: methodBuilder.addExtraSetter(maybeSetter); Should you be posting an error here if the dialect is standard? http://gwt-code-reviews.appspot.com/1355804/diff/1/12 File user/src/com/google/gwt/requestfactory/shared/JsonRpcContent.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/12#newcode26 user/src/com/google/gwt/requestfactory/shared/JsonRpcContent.java:26: * REST-style request. Not a rest style request http://gwt-code-reviews.appspot.com/1355804/diff/1/17 File user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/17#newcode91 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:91: interface DialectImpl { Can the DialectImpl's be broken out into their own files? Or are they just too inner for that? http://gwt-code-reviews.appspot.com/1355804/diff/1/17#newcode126 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:126: request.setVersion("2.0"); What's the magic number about? http://gwt-code-reviews.appspot.com/1355804/diff/1/17#newcode131 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:131: for (Map.Entry<String, Object> entry : data.getNamedParameters().entrySet()) { I know this would be a step backward, and has nothing to do with this patch, but let me get it off my chest: I can't shake the feeling some size and performance issues might go away if autobean could generate facades backed by jso objects, more in the style of the bad old RF implementation. Do lazy reification in getters; convert back to jso on set; that kind of thing. In theory you'd be ready for a simple call to stringify at a moment's notice. Horrible to debug and maintain, but now you have acres of unit tests to keep you sane. Maybe it's time? I suppose it wouldn't help with your plague-of-visitors issue. I guess one question is how much of the burden is acres of getFoo and setBar methods. Might such an approach eliminate some of the visitors? There, I'm done. http://gwt-code-reviews.appspot.com/1355804/diff/1/17#newcode192 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:192: class StandardPayloadDialect implements DialectImpl { Correct to presume that nothing changed here? http://gwt-code-reviews.appspot.com/1355804/diff/1/20 File user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/20#newcode114 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:114: * GET-style REST request. not rest http://gwt-code-reviews.appspot.com/1355804/diff/1/21 File user/src/com/google/gwt/requestfactory/shared/messages/JsonRpcRequest.java (right): http://gwt-code-reviews.appspot.com/1355804/diff/1/21#newcode24 user/src/com/google/gwt/requestfactory/shared/messages/JsonRpcRequest.java:24: * doc http://gwt-code-reviews.appspot.com/1355804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
