Reviewers: jgw,

Description:
Handle cases where element.canPlayType() returns 'no' instead of the
empty string on some browsers.

Review by: [email protected]

Please review this at http://gwt-code-reviews.appspot.com/1362802/

Affected files:
  M user/src/com/google/gwt/dom/client/MediaElement.java


Index: user/src/com/google/gwt/dom/client/MediaElement.java
===================================================================
--- user/src/com/google/gwt/dom/client/MediaElement.java        (revision 9755)
+++ user/src/com/google/gwt/dom/client/MediaElement.java        (working copy)
@@ -112,7 +112,11 @@
    *         {@link #CANNOT_PLAY}
    */
   public final native String canPlayType(String type) /*-{
-    return this.canPlayType(type);
+    var canPlayType = this.canPlayType(type);
+     // Some browsers report "no" instead of the empty string.
+     // See http://gwt-voices.appspot.com/
+    return canPlayType == "no" ?
+        @com.google.gwt.dom.client.MediaElement::CANNOT_PLAY : canPlayType;
   }-*/;

   /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to