Thank you for the patch! LGTM with a few nits. Lets get this into 2.3 and end this travesty of broken onload events forever :)
http://gwt-code-reviews.appspot.com/1353801/diff/1/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1353801/diff/1/user/src/com/google/gwt/user/client/ui/Frame.java#newcode124 user/src/com/google/gwt/user/client/ui/Frame.java:124: Add javadoc and move this method and move it below the protected Frame(Element element) method. (If Eclipse is set up to do it, Source->Sort Members will do the trick.) http://gwt-code-reviews.appspot.com/1353801/diff/1/user/test/com/google/gwt/dom/client/FrameTests.java File user/test/com/google/gwt/dom/client/FrameTests.java (right): http://gwt-code-reviews.appspot.com/1353801/diff/1/user/test/com/google/gwt/dom/client/FrameTests.java#newcode68 user/test/com/google/gwt/dom/client/FrameTests.java:68: @Override Remove this @Override. Sadly, until GWT2.3 is released, Java 1.5 compatibility is required which doesn't like @Override's on interfaces. http://gwt-code-reviews.appspot.com/1353801/diff/1/user/test/com/google/gwt/dom/client/FrameTests.java#newcode85 user/test/com/google/gwt/dom/client/FrameTests.java:85: @Override Remove this @Override (see above) http://gwt-code-reviews.appspot.com/1353801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
