Reviewers: zundel,

Description:
More autoformatter tweaks. Allow wrapping on assignments, do not
prefer outer expressions when wrapping, and change the line length to
100 (like everyone else at Google).

Because Toby rightly points out that
http://gwt-code-reviews.appspot.com/1368802 is heinous.


Please review this at http://gwt-code-reviews.appspot.com/1371802/

Affected files:
  M eclipse/settings/code-style/gwt-format.xml


Index: eclipse/settings/code-style/gwt-format.xml
===================================================================
--- eclipse/settings/code-style/gwt-format.xml  (revision 9736)
+++ eclipse/settings/code-style/gwt-format.xml  (working copy)
@@ -14,7 +14,7 @@
<setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_explicit_constructor_call" value="16"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_method_invocation" value="16"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_qualified_allocation_expression" value="16"/> -<setting id="org.eclipse.jdt.core.formatter.alignment_for_assignment" value="0"/> +<setting id="org.eclipse.jdt.core.formatter.alignment_for_assignment" value="16"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_binary_expression" value="16"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_compact_if" value="48"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_conditional_expression" value="16"/>
@@ -263,7 +263,7 @@
<setting id="org.eclipse.jdt.core.formatter.keep_empty_array_initializer_on_one_line" value="false"/> <setting id="org.eclipse.jdt.core.formatter.keep_imple_if_on_one_line" value="false"/> <setting id="org.eclipse.jdt.core.formatter.keep_then_statement_on_same_line" value="false"/>
-<setting id="org.eclipse.jdt.core.formatter.lineSplit" value="80"/>
+<setting id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/>
<setting id="org.eclipse.jdt.core.formatter.never_indent_block_comments_on_first_column" value="false"/> <setting id="org.eclipse.jdt.core.formatter.never_indent_line_comments_on_first_column" value="false"/> <setting id="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_beginning_of_method_body" value="0"/>
@@ -274,6 +274,6 @@
<setting id="org.eclipse.jdt.core.formatter.use_on_off_tags" value="false"/> <setting id="org.eclipse.jdt.core.formatter.use_tabs_only_for_leading_indentations" value="false"/> <setting id="org.eclipse.jdt.core.formatter.wrap_before_binary_operator" value="true"/> -<setting id="org.eclipse.jdt.core.formatter.wrap_outer_expressions_when_nested" value="true"/> +<setting id="org.eclipse.jdt.core.formatter.wrap_outer_expressions_when_nested" value="false"/>
 </profile>
 </profiles>


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to