On Wed, Mar 2, 2011 at 6:41 AM, <[email protected]> wrote: > LGTM: oops, looks like I never sent this comment > > > > http://gwt-code-reviews.appspot.com/1371802/diff/1/eclipse/settings/code-style/gwt-format.xml > File eclipse/settings/code-style/gwt-format.xml (right): > > > http://gwt-code-reviews.appspot.com/1371802/diff/1/eclipse/settings/code-style/gwt-format.xml#newcode266 > eclipse/settings/code-style/gwt-format.xml:266: <setting > > id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/> > I support this change to 100 character line lengths, but note that it > will be a change to the public GWT style guide. > > http://code.google.com/webtoolkit/makinggwtbetter.html#codestyle
Already updated. > > > Anyone using the autoformatter will likely reformat a lot of code for > existing files. Again, I support it, I just want everyone to go in with > that in mind. I'd be willing to go through and autoformat large swaths > of code once we consider this change stable if we can get enough buy in > from the rest of the team. > > > http://gwt-code-reviews.appspot.com/1371802/ > That would be generous of you. I can't imagine anyone complaining. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
