LGTM Just nits.
http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java File user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java#newcode56 user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java:56: * An array of length one, containing zero; not an array of length zero. eh? http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/autobean/client/impl/JsniCreatorMap.java File user/src/com/google/gwt/autobean/client/impl/JsniCreatorMap.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/autobean/client/impl/JsniCreatorMap.java#newcode23 user/src/com/google/gwt/autobean/client/impl/JsniCreatorMap.java:23: * Used in web-mode code to create instances of generated AutoBean subtypes via prod-mode http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java#newcode172 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:172: final Set<EntityProxyModel> models = new LinkedHashSet<EntityProxyModel>(); Mind refactoring all this into models = findModels(method);? http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/model/EntityProxyModel.java File user/src/com/google/gwt/requestfactory/rebind/model/EntityProxyModel.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/model/EntityProxyModel.java#newcode87 user/src/com/google/gwt/requestfactory/rebind/model/EntityProxyModel.java:87: if (visitor.visit(this)) { empty if body http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/model/RequestMethod.java File user/src/com/google/gwt/requestfactory/rebind/model/RequestMethod.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/rebind/model/RequestMethod.java#newcode131 user/src/com/google/gwt/requestfactory/rebind/model/RequestMethod.java:131: if (visitor.visit(this)) { ditto http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java#newcode412 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:412: throw new IllegalArgumentException("Unknown EntityProxy type " Not necessarily an EntityProxy http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestFactory.java File user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestFactory.java (right): http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestFactory.java#newcode126 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestFactory.java:126: * removed. I thought you were solving exactly that pruning problem in this patch? http://gwt-code-reviews.appspot.com/1369803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
