http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):
http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode154 user/src/com/google/gwt/user/tools/WebAppCreator.java:154: templates.remove("eclipse"); On 2011/03/05 21:42:11, jlabanca wrote:
Can you add a comment explaining why these are removed? If they are incompatible, can we log a warning.
Done. This is to allow the default arguments work with '-maven' Ant and eclipse are removed so that no eclipse or ant artifacts get generated along with the pom.xml. Maven developers have other mechanisms to handle Eclipse and Ant. http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode214 user/src/com/google/gwt/user/tools/WebAppCreator.java:214: templates.remove("ant"); On 2011/03/05 21:42:11, jlabanca wrote:
I think a warning or even an error would be appropriate for
conflicting options. Done. Also added errors for other conflicting cases: maven-vs-onlyEclipse and noEclipse-vs-onlyEclipse http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode330 user/src/com/google/gwt/user/tools/WebAppCreator.java:330: templates.add(template); On 2011/03/05 21:42:11, jlabanca wrote:
Will add duplicates. I recommend using a Set for templates.
Done. http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode352 user/src/com/google/gwt/user/tools/WebAppCreator.java:352: + ", sourceName=" + sourceName + "isBinary=" + isBinary + "]"; On 2011/03/05 21:42:11, jlabanca wrote:
"isBinary=" => ", isBinary="
Done. http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode363 user/src/com/google/gwt/user/tools/WebAppCreator.java:363: On 2011/03/05 21:42:11, jlabanca wrote:
spaces
Done. http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode403 user/src/com/google/gwt/user/tools/WebAppCreator.java:403: private ArrayList<String> templates = new ArrayList<String>(); On 2011/03/05 21:42:11, jlabanca wrote:
A Set might be better to avoid duplicates.
Done. http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode511 user/src/com/google/gwt/user/tools/WebAppCreator.java:511: // maven project. Maven projects should include libs as maven dependencies. On 2011/03/05 21:42:11, jlabanca wrote:
Are you sure its safe to remove the !maven check?
Yes, I checked. The generated pom.xml does not use "@copyServletDeps" and the maven option removes ant and eclipse from the generated templates. I moved the removal of ant and eclipse later in the processing just to make sure maven never gets generated along with ant nor eclipse templates. http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
