http://gwt-code-reviews.appspot.com/1305801/diff/48001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):
http://gwt-code-reviews.appspot.com/1305801/diff/48001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode701 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:701: public String tokenForStringExpression(String expression) { Yeah, that's what I was asking. Oh well. On 2011/03/06 20:56:11, sbrubaker wrote:
On 2011/03/02 23:27:35, rjrjr wrote: > Is it ever the case that the same token will be reach both > HtmlTemplate#populateArgMap, and a spot where \" + stuff is needed? > > If not, should rename this tokenForInlineStringExpression(), and add
a new
> method without the quotes and a name like
tokenForStringInHtmlTemplate. And
> rename tokenForSafeHtmlExpression to
tokenForTrustedHtmlInHtmlTemplate.
> > This would allow you to get rid of the other substring(4 calls in > HtmlTemplate#populateArgMap
While I understand what you're getting at, how do I distinguish when
to call
tokenForInlineStringExpression vs. tokenForStringInHtmlTemplate? The
issue is
that declareDomField would need to call either of these depending on
the
context, but all that is passed to declareDomField is the field name.
There is
not enough information to determine which of the two to call.
http://gwt-code-reviews.appspot.com/1305801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
