[gwt-contrib] [google-web-toolkit] r9829 committed - Let the Key for Maps be of type Object....

Wed, 09 Mar 2011 14:12:12 -0800 

Revision: 9829
Author: gwt.mirror...@gmail.com
Date: Wed Mar  9 14:11:18 2011
Log: Let the Key for Maps be of type Object.

[JSR 303 TCK Result] 110 of 257 (42.80%) Pass with 20 Failures and 9 Errors.

Review at http://gwt-code-reviews.appspot.com/1376803

Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9829

Modified:
/trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java /trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java /trunk/user/test/org/hibernate/jsr303/tck/tests/validation/PropertyPathGwtTest.java 

=======================================
--- /trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java Wed Mar 2 06:32:23 2011 +++ /trunk/user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java Wed Mar 9 14:11:18 2011 
@@ -102,10 +102,9 @@
   /**
    * Append a keyed node to the path.
    *
-   * @param name
    * @return the new GwtValidationContext.
    */
-  public GwtValidationContext<T> appendKey(String name, String key) {
+  public GwtValidationContext<T> appendKey(String name, Object key) {
     GwtValidationContext<T> temp = new GwtValidationContext<T>(rootBean,
         beanDescriptor, messageInterpolator, validator, validatedObjects);
     temp.path = path.appendKey(name, key);
=======================================
--- /trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java Wed Mar 2 06:32:23 2011 +++ /trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java Wed Mar 9 14:11:18 2011 
@@ -1182,10 +1182,10 @@
     sw.indent();
     sw.indent();

-    // context.appendKey("myProperty",String.valueOf(entry.getKey())),
+    // context.appendKey("myProperty",entry.getKey()),
     sw.print("context.appendKey(\"");
     sw.print(p.getPropertyName());
-    sw.println("\",String.valueOf(entry.getKey())),");
+    sw.println("\",entry.getKey()),");

     // entry.getValue(), groups));
     sw.println("entry.getValue(), groups));");
=======================================
--- /trunk/user/test/org/hibernate/jsr303/tck/tests/validation/PropertyPathGwtTest.java Mon Feb 7 07:41:58 2011 +++ /trunk/user/test/org/hibernate/jsr303/tck/tests/validation/PropertyPathGwtTest.java Wed Mar 9 14:11:18 2011 
@@ -48,7 +48,6 @@
     delegate.testPropertyPathWithList();
   }

-  @Failing(issue = 5803)
   public void testPropertyPathWithMap() {
     delegate.testPropertyPathWithMap();
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to