LGTM

This is awesome!


http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
(right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java#newcode164
dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:164:
logger.log(TreeLogger.WARN, "Could not find an exact match rule. Using
'closest' rule " +
I would prefer an INFO here. The only way to get rid of the warning is
to add a rule for IE9 to every deferred binding, which suggests that
falling back is "wrong". I don't really agree with that, and I'm worried
that this is going to spam builds.

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplIE9.java
File user/src/com/google/gwt/dom/client/DOMImplIE9.java (right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplIE9.java#newcode2
user/src/com/google/gwt/dom/client/DOMImplIE9.java:2: * Copyright 2010
Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
(right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java#newcode2
user/src/com/google/gwt/dom/client/DOMImplStandardBase.java:2: *
Copyright 2010 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplWebkit.java
File user/src/com/google/gwt/dom/client/DOMImplWebkit.java (right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplWebkit.java#newcode2
user/src/com/google/gwt/dom/client/DOMImplWebkit.java:2: * Copyright
2010 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Tree.gwt.xml
File user/src/com/google/gwt/user/Tree.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Tree.gwt.xml#newcode26
user/src/com/google/gwt/user/Tree.gwt.xml:26: <when-property-is
name="user.agent" value="ie9"/>
Use consistent tabs, or convert all to spaces.

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Window.gwt.xml
File user/src/com/google/gwt/user/Window.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Window.gwt.xml#newcode28
user/src/com/google/gwt/user/Window.gwt.xml:28: <when-property-is
name="user.agent" value="ie9"/>
convert to spaces

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplIE9.java
File user/src/com/google/gwt/user/client/impl/DOMImplIE9.java (right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplIE9.java#newcode2
user/src/com/google/gwt/user/client/impl/DOMImplIE9.java:2: * Copyright
2008 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java
(right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java#newcode2
user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java:2: *
Copyright 2008 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java
File user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java
(right):

http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java#newcode2
user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java:2: *
Copyright 2008 Google Inc.
2011

http://gwt-code-reviews.appspot.com/1383801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to