Revision: 9842
Author: [email protected]
Date: Fri Mar 11 06:21:13 2011
Log: Clean up pesky UiBinder warnings
Review at http://gwt-code-reviews.appspot.com/1380802
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=9842
Modified:
/trunk/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
/trunk/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
/trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
/trunk/user/src/com/google/gwt/uibinder/rebind/Statements.java
/trunk/user/src/com/google/gwt/uibinder/rebind/W3cDocumentBuilder.java
/trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java
/trunk/user/src/com/google/gwt/uibinder/rebind/messages/PlaceholderInterpreter.java
/trunk/user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DockLayoutPanelParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ImageParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/IsEmptyParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ListBoxParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UIObjectParserTest.java
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UiChildParserTest.java
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
Tue Jun 22 06:26:45 2010
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
Fri Mar 11 06:21:13 2011
@@ -45,10 +45,10 @@
/**
* Interpreters are fired in the order they were handed to the
constructor. If
- * an interpretter gives a non-null result, downstream interpretters
don't
+ * an interpreter gives a non-null result, downstream interpreters don't
* fire.
*
- * @return The T or null returned by the last pipelined interpretter to
run
+ * @return The T or null returned by the last pipelined interpreter to
run
* @throws UnableToCompleteException on error
*/
public T interpretElement(XMLElement elem) throws
UnableToCompleteException {
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
Tue Oct 5 11:03:13 2010
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
Fri Mar 11 06:21:13 2011
@@ -97,7 +97,8 @@
}
/**
- * Process a child element that should be added using a {@link UiChild}
method.
+ * Process a child element that should be added using a
+ * {@link com.google.gwt.uibinder.client.UiChild UiChild} method.
*/
private void handleChild(XMLElement child) throws
UnableToCompleteException {
String tag = child.getLocalName();
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/FieldManager.java Wed
Nov 11 22:08:47 2009
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/FieldManager.java Fri
Mar 11 06:21:13 2011
@@ -87,8 +87,8 @@
* When making a field we peek at the {@link #parsedFieldStack} to make
sure
* that the field that holds the widget currently being parsed will
depended
* upon the field being declared. This ensures, for example, that dom id
- * fields (see {@link #declareDomIdHolder()}) used by an HTMLPanel will
be
- * declared before it is.
+ * fields (see {@link UiBinderWriter#declareDomIdHolder()}) used by an
HTMLPanel
+ * will be declared before it is.
*
* @param fieldType the type of the new field
* @param fieldName the name of the new field
@@ -112,8 +112,8 @@
* When making a field we peek at the {@link #parsedFieldStack} to make
sure
* that the field that holds the widget currently being parsed will
depended
* upon the field being declared. This ensures, for example, that dom id
- * fields (see {@link #declareDomIdHolder()}) used by an HTMLPanel will
be
- * declared before it is.
+ * fields (see {@link UiBinderWriter#declareDomIdHolder()}) used by an
HTMLPanel
+ * will be declared before it is.
*
* @throws UnableToCompleteException on duplicate name
* @return a new {@link FieldWriter} instance
@@ -134,8 +134,8 @@
* When making a field we peek at the {@link #parsedFieldStack} to make
sure
* that the field that holds the widget currently being parsed will
depended
* upon the field being declared. This ensures, for example, that dom id
- * fields (see {@link #declareDomIdHolder()}) used by an HTMLPanel will
be
- * declared before it is.
+ * fields (see {@link UiBinderWriter#declareDomIdHolder()}) used by an
HTMLPanel
+ * will be declared before it is.
*
* @param assignableType class or interface extened or implemented by
this
* type
@@ -156,8 +156,6 @@
/**
* Called to register a <code>{field.reference}</code> encountered during
* parsing, to be validated against the type oracle once parsing is
complete.
- *
- * @throws UnableToCompleteException
*/
public void registerFieldReference(String fieldReferenceString, JType
type) {
FieldReference fieldReference =
fieldReferences.get(fieldReferenceString);
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java Fri
Oct 8 06:15:38 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java Fri Mar
11 06:21:13 2011
@@ -72,16 +72,15 @@
/**
* Used to provide an initializer string to use instead of a
- * {@link com.google.gwt.core.client.GWT#create()} call. Note that this
is an
+ * {@link com.google.gwt.core.client.GWT#create} call. Note that this is
an
* RHS expression. Don't include the leading '=', and don't end it
with ';'.
*
- * @throws UnableToCompleteException
* @throws IllegalStateException on second attempt to set the initializer
*/
void setInitializer(String initializer);
/**
- * Write the field delcaration.
+ * Write the field declaration.
*/
void write(IndentedWriter w) throws UnableToCompleteException;
}
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/Statements.java Fri Jul
23 14:20:15 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/Statements.java Fri Mar
11 06:21:13 2011
@@ -47,7 +47,7 @@
*
* @param format
* @param args
- * @see #beginAttachedSection(String)
+ * @see UiBinderWriter#beginAttachedSection(String)
*/
void addDetachStatement(String format, Object... args);
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/W3cDocumentBuilder.java
Mon Jun 14 13:37:36 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/W3cDocumentBuilder.java
Fri Mar 11 06:21:13 2011
@@ -26,11 +26,9 @@
import org.xml.sax.Attributes;
import org.xml.sax.InputSource;
import org.xml.sax.Locator;
-import org.xml.sax.SAXException;
import org.xml.sax.SAXParseException;
import org.xml.sax.ext.DefaultHandler2;
-import java.io.IOException;
import java.util.Stack;
import javax.xml.parsers.DocumentBuilderFactory;
@@ -100,7 +98,7 @@
@Override
public InputSource resolveEntity(String name, String publicId,
- String baseURI, String systemId) throws SAXException, IOException {
+ String baseURI, String systemId) {
return resolver.resolveEntity(publicId, systemId);
}
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java Fri Oct
8 06:15:38 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java Fri Mar
11 06:21:13 2011
@@ -419,9 +419,9 @@
* <p>
* This call requires an interpreter to make sense of any special
children.
* The odds are you want to use
- * {@link
com.google.gwt.uibinder.elementparsers.templates.parsers.HtmlInterpreter}
+ * {@link com.google.gwt.uibinder.elementparsers.HtmlInterpreter}
* for an HTML value, or
- * {@link
com.google.gwt.uibinder.elementparsers.templates.parsers.TextInterpreter}
+ * {@link com.google.gwt.uibinder.elementparsers.TextInterpreter}
* for text.
*
* @param interpreter Called for each element, expected to return a
string
@@ -467,7 +467,7 @@
* <p>
* This call requires an interpreter to make sense of any special
children.
* The odds are you want to use
- * {@link
com.google.gwt.uibinder.elementparsers.templates.parsers.TextInterpreter}
+ * {@link com.google.gwt.uibinder.elementparsers.TextInterpreter}
*
* @throws UnableToCompleteException If any elements present are not
consumed
* by the interpreter
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/rebind/messages/PlaceholderInterpreter.java
Mon Jun 7 12:20:31 2010
+++
/trunk/user/src/com/google/gwt/uibinder/rebind/messages/PlaceholderInterpreter.java
Fri Mar 11 06:21:13 2011
@@ -112,7 +112,7 @@
* @param name
* @param example
* @param value
- * @return
+ * @return the token to replace the input String's placeholder
*/
protected String nextPlaceholder(String name, String example, String
value) {
message.addPlaceholder(new PlaceholderWriter(name, example, value));
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java
Wed Nov 4 11:14:50 2009
+++
/trunk/user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java
Fri Mar 11 06:21:13 2011
@@ -62,7 +62,7 @@
* @param body the inline css text
* @param importTypes for the {@literal @}Import annotation, if any.
LinkedHashSet
* to enforce deterministic order across recompiles
- * @return
+ * @return the newly-created CssResource
*/
public ImplicitCssResource createCssResource(String name, String[]
source,
JClassType extendedInterface, String body, LinkedHashSet<JClassType>
importTypes) {
@@ -78,7 +78,7 @@
*
* @param name the method name and the ui:field name
* @param source path to the resource
- * @return
+ * @return the newly-created DataResource
*/
public ImplicitDataResource createDataResource(String name, String
source) {
ImplicitDataResource data = new ImplicitDataResource(name, source);
@@ -95,7 +95,7 @@
* specified
* @param repeatStyle value of the RepeatStyle ImageOption, or null if
none
* was specified
- * @return
+ * @return the newly-created ImageResource
*/
public ImplicitImageResource createImageResource(String name, String
source,
Boolean flipRtl, RepeatStyle repeatStyle) {
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
Thu Jan 13 12:25:22 2011
+++
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
Fri Mar 11 06:21:13 2011
@@ -368,7 +368,7 @@
*
* The cost mapping is defined in
* {@link #TYPE_RANK typeRank }
- * @param method.
+ * @param method
* @return the rank of the method.
*/
private int rankMethodOnParameters(JMethod method) {
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
Wed Mar 9 09:01:28 2011
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
Fri Mar 11 06:21:13 2011
@@ -24,7 +24,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
import java.util.Iterator;
/**
@@ -69,8 +68,7 @@
tester = new ElementParserTester(PARSED_TYPE, new DialogBoxParser());
}
- public void testHappy() throws UnableToCompleteException, SAXException,
- IOException {
+ public void testHappy() throws UnableToCompleteException, SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -93,8 +91,7 @@
assertNull(tester.logger.died);
}
- public void testNoCaption() throws UnableToCompleteException,
SAXException,
- IOException {
+ public void testNoCaption() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -110,8 +107,7 @@
assertNull(tester.logger.died);
}
- public void testDefaults() throws UnableToCompleteException,
SAXException,
- IOException {
+ public void testDefaults() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox/> ");
@@ -124,7 +120,7 @@
assertNull(tester.logger.died);
}
- public void testCustomCaptionAndCaption() throws SAXException,
IOException,
+ public void testCustomCaptionAndCaption() throws SAXException,
UnableToCompleteException {
StringBuffer b = new StringBuffer();
@@ -151,7 +147,7 @@
}
}
- public void testWidgetInCaption() throws SAXException, IOException {
+ public void testWidgetInCaption() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -168,7 +164,7 @@
}
}
- public void testTooManyCaptionWidgets() throws SAXException, IOException,
+ public void testTooManyCaptionWidgets() throws SAXException,
UnableToCompleteException {
StringBuffer b = new StringBuffer();
@@ -194,8 +190,7 @@
}
}
- public void testCustomCaption() throws SAXException, IOException,
- UnableToCompleteException {
+ public void testCustomCaption() throws SAXException,
UnableToCompleteException {
StringBuffer b = new StringBuffer();
DialogBoxParser parser = new DialogBoxParser();
@@ -229,8 +224,7 @@
assertNull(tester.logger.died);
}
- public void testCaptionWidgetDoesntImplementCaption() throws
SAXException,
- IOException {
+ public void testCaptionWidgetDoesntImplementCaption() throws
SAXException {
StringBuffer b = new StringBuffer();
@@ -248,7 +242,7 @@
}
}
- public void testTooManyBodies() throws SAXException, IOException {
+ public void testTooManyBodies() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -264,7 +258,7 @@
}
}
- public void testTooManyCaptions() throws SAXException, IOException {
+ public void testTooManyCaptions() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -280,7 +274,7 @@
}
}
- public void testBadCaptionWidgetContent() throws SAXException,
IOException {
+ public void testBadCaptionWidgetContent() throws SAXException {
StringBuffer b = new StringBuffer();
@@ -298,7 +292,7 @@
}
}
- public void testBadElemContent() throws SAXException, IOException {
+ public void testBadElemContent() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -313,7 +307,7 @@
}
}
- public void testBadTextContent() throws SAXException, IOException {
+ public void testBadTextContent() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DialogBox autoHide='true' modal='true'>");
@@ -331,7 +325,7 @@
}
public void testSubclassOkay() throws UnableToCompleteException,
- SAXException, IOException {
+ SAXException {
DialogBoxParser parser = new DialogBoxParser();
String typeName = "my.MyDialogBox";
tester = new ElementParserTester(typeName, parser, DIALOG_SUBCLASS);
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DockLayoutPanelParserTest.java
Wed Nov 11 22:08:47 2009
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/DockLayoutPanelParserTest.java
Fri Mar 11 06:21:13 2011
@@ -22,7 +22,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
import java.util.Iterator;
/**
@@ -40,7 +39,7 @@
tester = new ElementParserTester(PARSED_TYPE, new
DockLayoutPanelParser());
}
- public void testBadChild() throws SAXException, IOException {
+ public void testBadChild() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel unit='EM'>");
b.append(" <g:west><foo/></g:west>");
@@ -55,8 +54,7 @@
}
}
- public void testHappy() throws UnableToCompleteException, SAXException,
- IOException {
+ public void testHappy() throws UnableToCompleteException, SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel unit='EM'>");
b.append(" <g:north size='5'>");
@@ -83,8 +81,7 @@
assertNull(tester.logger.died);
}
- public void testNiceCenter() throws UnableToCompleteException,
SAXException,
- IOException {
+ public void testNiceCenter() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel unit='EM'>");
b.append(" <g:center>");
@@ -110,7 +107,7 @@
assertFalse(i.hasNext());
}
- public void testTooManyCenters() throws SAXException, IOException {
+ public void testTooManyCenters() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel unit='EM'>");
b.append(" <g:center>");
@@ -129,8 +126,7 @@
}
}
- public void testNoUnits() throws SAXException, IOException,
- UnableToCompleteException {
+ public void testNoUnits() throws SAXException, UnableToCompleteException
{
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel>");
b.append("</g:DockLayoutPanel>");
@@ -143,7 +139,7 @@
assertFalse(i.hasNext());
}
- public void testNoSize() throws SAXException, IOException {
+ public void testNoSize() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:DockLayoutPanel>");
b.append(" <g:north>");
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ImageParserTest.java
Fri Apr 2 07:37:08 2010
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ImageParserTest.java
Fri Mar 11 06:21:13 2011
@@ -23,8 +23,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
-
/**
* Eponymous unit test.
*/
@@ -66,7 +64,7 @@
}
public void testHappyWithDefaultInstantiableSubclass()
- throws UnableToCompleteException, SAXException, IOException {
+ throws UnableToCompleteException, SAXException {
tester = new ElementParserTester("my.MyImage", new ImageParser(),
IMAGE_SUBCLASS_NO_CONSTRUCTOR,
IMAGE_SUBCLASS_RESOURCE_CONSTRUCTOR);
ImageParser parser = new ImageParser();
@@ -88,7 +86,7 @@
}
public void testHappyWithSubclassWithImageResourceConstructor()
- throws UnableToCompleteException, SAXException, IOException {
+ throws UnableToCompleteException, SAXException {
ImageParser parser = new ImageParser();
tester = new ElementParserTester("my.MyConstructedImage", new
ImageParser(),
IMAGE_SUBCLASS_NO_CONSTRUCTOR,
IMAGE_SUBCLASS_RESOURCE_CONSTRUCTOR);
@@ -112,7 +110,7 @@
}
public void testHappyWithResource() throws UnableToCompleteException,
- SAXException, IOException {
+ SAXException {
StringBuffer b = new StringBuffer();
b.append("<ui:Image field='someImageResource' />");
b.append("<g:Image resource='{someImageResource}' >");
@@ -127,7 +125,7 @@
}
public void testHappyWithNoResource() throws UnableToCompleteException,
- SAXException, IOException {
+ SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:Image>");
b.append("</g:Image>");
@@ -139,7 +137,7 @@
assertNull(tester.logger.died);
}
- public void testChokeOnNonResource() throws SAXException, IOException {
+ public void testChokeOnNonResource() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:Image resource='someString' >");
b.append("</g:Image>");
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/IsEmptyParserTest.java
Tue Nov 10 12:33:30 2009
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/IsEmptyParserTest.java
Fri Mar 11 06:21:13 2011
@@ -21,8 +21,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
-
/**
* A unit test. Guess what of.
*/
@@ -37,7 +35,7 @@
tester = new ElementParserTester(PARSED_TYPE, new IsEmptyParser());
}
- public void testExtraText() throws SAXException, IOException {
+ public void testExtraText() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject>");
b.append(" I have some extra");
@@ -52,7 +50,7 @@
}
}
- public void testExtraChildren() throws SAXException, IOException {
+ public void testExtraChildren() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject>");
b.append(" <blorp />");
@@ -67,7 +65,7 @@
}
}
- public void testExtraAttributes() throws SAXException, IOException {
+ public void testExtraAttributes() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject blip='blap' blorp='bloop'>");
b.append("</g:UIObject>");
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ListBoxParserTest.java
Thu Feb 25 12:09:02 2010
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/ListBoxParserTest.java
Fri Mar 11 06:21:13 2011
@@ -21,7 +21,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
import java.util.Iterator;
/**
@@ -38,7 +37,7 @@
tester = new ElementParserTester(PARSED_TYPE, new ListBoxParser());
}
- public void testChildWithWhitespaces() throws UnableToCompleteException,
SAXException, IOException {
+ public void testChildWithWhitespaces() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:ListBox>");
b.append(" <g:item> </g:item>");
@@ -57,7 +56,7 @@
assertNull(tester.logger.died);
}
- public void testEmtpyChild() throws UnableToCompleteException,
SAXException, IOException {
+ public void testEmptyChild() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:ListBox>");
b.append(" <g:item></g:item>");
@@ -76,7 +75,7 @@
assertNull(tester.logger.died);
}
- public void testInvalidChild() throws SAXException, IOException {
+ public void testInvalidChild() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:ListBox>");
b.append(" <foo/>");
@@ -90,8 +89,7 @@
}
}
- public void testValidChild() throws UnableToCompleteException,
SAXException,
- IOException {
+ public void testValidChild() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:ListBox>");
b.append(" <g:item>");
@@ -117,7 +115,7 @@
assertNull(tester.logger.died);
}
- public void testWidgetAsChild() throws SAXException, IOException {
+ public void testWidgetAsChild() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:ListBox>");
b.append(" <g:item>");
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java
Wed Mar 9 09:01:28 2011
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java
Fri Mar 11 06:21:13 2011
@@ -56,8 +56,7 @@
}
@Override
- public String parseElementToField(XMLElement elem)
- throws UnableToCompleteException {
+ public String parseElementToField(XMLElement elem) {
return elem.consumeOpeningTag();
}
}
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UIObjectParserTest.java
Fri Jan 15 09:24:24 2010
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UIObjectParserTest.java
Fri Mar 11 06:21:13 2011
@@ -21,7 +21,6 @@
import org.xml.sax.SAXException;
-import java.io.IOException;
import java.util.Iterator;
/**
@@ -38,8 +37,7 @@
tester = new ElementParserTester(PARSED_TYPE, new UIObjectParser());
}
- public void testHappy() throws UnableToCompleteException, SAXException,
- IOException {
+ public void testHappy() throws UnableToCompleteException, SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject debugId='blat' styleName='primary' "
+ "addStyleNames='foo, bar baz'");
@@ -65,8 +63,7 @@
assertNull(tester.logger.died);
}
- public void testSetPrimary() throws UnableToCompleteException,
SAXException,
- IOException {
+ public void testSetPrimary() throws UnableToCompleteException,
SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject stylePrimaryName='primary' >");
b.append("</g:UIObject>");
@@ -83,7 +80,7 @@
assertNull(tester.logger.died);
}
- public void testStyleConflict() throws SAXException, IOException {
+ public void testStyleConflict() throws SAXException {
StringBuffer b = new StringBuffer();
b.append("<g:UIObject stylePrimaryName='primary'
styleName='otherPrimary'>");
b.append("</g:UIObject>");
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UiChildParserTest.java
Thu Sep 9 08:24:17 2010
+++
/trunk/user/test/com/google/gwt/uibinder/elementparsers/UiChildParserTest.java
Fri Mar 11 06:21:13 2011
@@ -134,25 +134,23 @@
assertNull("Parser should never set an initializer.",
w.getInitializer());
}
- public void testIncompatibleChild() throws SAXParseException,
- UnableToCompleteException {
+ public void testIncompatibleChild() throws SAXParseException {
String b = UIBINDER.replaceAll(CHILDREN, "<g:child> <div/>
</g:child>");
try {
- FieldWriter w = tester.parse(b);
+ tester.parse(b);
fail("Incompatible type should have thrown an error.");
} catch (UnableToCompleteException exception) {
assertEquals(0, tester.writer.statements.size());
}
}
- public void testMultipleChildrenInvalid() throws SAXParseException,
- UnableToCompleteException {
+ public void testMultipleChildrenInvalid() throws SAXParseException {
String b = UIBINDER.replaceAll(CHILDREN,
"<g:child ><g:Label/><g:Label/></g:child>");
try {
- FieldWriter w = tester.parse(b.toString());
+ tester.parse(b.toString());
fail("Cannot have multiple children under an @UiChild tag.");
} catch (UnableToCompleteException exception) {
assertEquals(0, tester.writer.statements.size());
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors