http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java
File user/src/com/google/gwt/user/client/ui/Frame.java (right):

http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78
user/src/com/google/gwt/user/client/ui/Frame.java:78:
sinkEvents(Event.ONLOAD);
Don't sink in the constructor unless its used by the Widget itself.
addDomHandler will lazily sink the load event automatically.  This is
important because sinking events is expensive.

http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode110
user/src/com/google/gwt/user/client/ui/Frame.java:110: return
addHandler(handler, LoadEvent.getType());
Use addDomHandler() for events that wrap native events.  It will sink
ONLOAD the first time it is called.

http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/test/com/google/gwt/dom/public-test/iframetest.html
File user/test/com/google/gwt/dom/public-test/iframetest.html (right):

http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/test/com/google/gwt/dom/public-test/iframetest.html#newcode3
user/test/com/google/gwt/dom/public-test/iframetest.html:3: </html>
This doesn't look right

http://gwt-code-reviews.appspot.com/1294801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to