ServiceInheritanceTest is still missing from RequestContextSuite (not Jre)
http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java File user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java (right): http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java#newcode60 user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:60: (Class<? extends RequestContext>) declaringClass; Use RequestContext.class.asSubclass(declaringClass) instead of a cast. And then maybe catch the ClassCastException instead of testing isAssignableFrom http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java#newcode64 user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:64: return die(null, "Method %s is not declared in a RequestContext interface", contextMethod); Should you use a format argument and RequestContext.class.getSimpleName()? (or getName()?)à http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/ResolverServiceLayer.java File user/src/com/google/gwt/requestfactory/server/ResolverServiceLayer.java (right): http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/ResolverServiceLayer.java#newcode124 user/src/com/google/gwt/requestfactory/server/ResolverServiceLayer.java:124: (Class<? extends RequestContext>) declaringClass; Same here. http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/ServiceLayer.java File user/src/com/google/gwt/requestfactory/server/ServiceLayer.java (right): http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/ServiceLayer.java#newcode337 user/src/com/google/gwt/requestfactory/server/ServiceLayer.java:337: * Given a {@link RequestContext} method, find the service class referenced in s/method/interface/ http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/ServiceLayer.java#newcode340 user/src/com/google/gwt/requestfactory/server/ServiceLayer.java:340: * @param requestContextClass a RequestContext interface should RequestContext be {@link}ed here? http://gwt-code-reviews.appspot.com/1384802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
