http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java (right):
http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java#newcode104 dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:104: private static boolean isDefaultExcluded(String path) { Could this all be represented by a single regex which could be compiled once? E.g., static final String EXCLUDES = "^((.*/CVS)|(.*/CVS/.*)|(CVS/.*)|" + "(.*/\.svn)|(.*/\.svn/.*)|(\.svn/.*)|(.*/\.svnignore)|" + "(.*/\.git)|(.*/\.git/.*)|(\.git/.*)|(.*/\.gitignore)|" + "(.*/SCCS)|(.*/SCCS/.*)|" + "(.*/vssver\.scc)|" + "(.*/\.DS_Store))$"; static final Pattern EXCLUDE_PATTERN = Pattern.compile(EXCLUDES); private static boolean isDefaultExcluded(String path) { return EXCLUDE_PATTERN.matcher(path).matches(); } http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java (right): http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java#newcode37 dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java:37: this.pathParts = path.split("/"); For a constant REGX, t's always better to rewrite "input.split(REGEX)" as: static final REGEX_PATTERN = Pattern.compile(REGEX); REGEX_PATTERN.split(input); to avoid compiling every time. http://gwt-code-reviews.appspot.com/1382801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
