To your specific questions: On Fri, Mar 18, 2011 at 1:02 PM, Ray Ryan <[email protected]> wrote:
> Thanks for the patches! > > No on noticed them because you didn't set a reviewer. Since you are > addressing specific items on the issue tracker, the owners of those tickets > would be the right targets. It's also a good idea to append the urls of the > patches to the tickets. > > rjrjr > > > On Fri, Mar 18, 2011 at 10:31 AM, Antoine DESSAIGNE < > [email protected]> wrote: > >> Hi, >> >> I wanted to know more about GWT and therefore I decided to try fixing some >> of the issues. >> >> I've followed the "Making it better" page as well as the help on >> "upload.py". I've proposed 3 patches ([1], [2] and [3]) but none of them >> appeared on this mailing-list nor were commented/reviewed. I'm wondering >> whether I forgot something or if you simply didn't have time to have a look >> at them. >> >> So I have several questions: >> - Am I proposing patches the right way ? >> > You did fine, you just missed step 8 in http://code.google.com/webtoolkit/makinggwtbetter.html#submittingpatches - How do you fix new issues: do you revert your code base after each patch >> submission, or do you have an easier way ? >> > Most of us use git, and make a separate branch for each fix > - Since I'm not sure if I will be able to fix an issue, should I send an >> email to this list before looking at it ? How should I tell you that i'm >> working on something ? >> > An issue tracker ticket is the best forum > >> Also, I have a more technical question: what's the right way to handle CSS >> and messages in the client.ui package: CssResource (with new CSS files) and >> Constants ? >> > Yes for CssResource. If this is in the context of a new widget, refer to this recent discussion: https://groups.google.com/d/topic/google-web-toolkit-contributors/SclEt5RzbvA/discussion Re: messages, that's an excellent question. John and John? > >> Thanks a lot for your insights on this matter. >> >> Antoine. >> >> [1] http://gwt-code-reviews.appspot.com/1369811/ >> [2] http://gwt-code-reviews.appspot.com/1383802/ >> [3] http://gwt-code-reviews.appspot.com/1388802/ >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
