Per our discussion, an overhaul of the event system is required to get
all the media events in, but I think these look good for now. I think
the Error and LoadedData events would also be useful if you have the
time.

Lastly, could you add tests for these events? You may be blocked on the
Audio and Video tests being disabled--if that's so, I am about to put up
a review that re-enables the Audio and Video tests, do you mind waiting
for that to land?


http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/EndedHandler.java
File user/src/com/google/gwt/event/dom/client/EndedHandler.java (right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/EndedHandler.java#newcode26
user/src/com/google/gwt/event/dom/client/EndedHandler.java:26: * Called
when EndEdEvent is fired.
EndEdEvent -> EndedEvent

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java
File user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java
(right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java#newcode2
user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java:2: *
Copyright 2010 Google Inc.
2010 -> 2011

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java#newcode25
user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java:25: *
to it. Therefore, updates can cause breaking API changes.
For consistency, could this be replaced with the experimental warning we
use in some of the other html5 apis?

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java
File
user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java
(right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java#newcode2
user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java:2:
* Copyright 2010 Google Inc.
2010 -> 2011

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java
File user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java
(right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java#newcode2
user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java:2: *
Copyright 2010 Google Inc.
2010 -> 2011

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java
File user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java
(right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java#newcode2
user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java:2: *
Copyright 2010 Google Inc.
2010 -> 2011

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java
File user/src/com/google/gwt/media/client/Audio.java (right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java#newcode93
user/src/com/google/gwt/media/client/Audio.java:93:
Can you add javadoc to these?

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Video.java
File user/src/com/google/gwt/media/client/Video.java (right):

http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Video.java#newcode100
user/src/com/google/gwt/media/client/Video.java:100:
Can you add javadoc to these?

http://gwt-code-reviews.appspot.com/1385804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to