LGTM
http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java (right): http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java#newcode97 dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java:97: private final Map<PathPrefixSet, ZipFileSnapshot> cachedSnapshots = new ReferenceIdentityMap( Agreed, I think a ReferenceIdentityMap (or a regular IdentityHashMap) is in practice like a "weak" map, since you can't access values if you lose reference to the key. However, I don't think it means the ReferenceIdentityMap will automatically lose it, if it is initialized to use HARD keys. So, if you had HARD keys, but lost the reference to a key, then you could still find the value by iterating over the values(). http://gwt-code-reviews.appspot.com/1388803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
