http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):
http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode204 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:204: final ArrayList<CompilationUnit> newlyBuiltUnits = new ArrayList<CompilationUnit>(); My first thought, was that this might be chance for parallelism, can we have multiple threads doing compilation here at once? Could use a thread pool executor here, and take advantage of multiple cpus. Seems that compilation is a compute intensive task that would scale over threads, no? (A general refrain from me, let's use more CPU's, and TPE = good). http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java (right): http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java#newcode317 dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java:317: } close ois? http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java File dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java (right): http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java#newcode74 dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java:74: } perhaps move out.close() to a finally block, to assure it gets closed if an exception. http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java File dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java (right): http://gwt-code-reviews.appspot.com/1384807/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java#newcode288 dev/core/src/com/google/gwt/dev/jjs/ast/JDeclaredType.java:288: Can you add a comment describing what the intention is for this? http://gwt-code-reviews.appspot.com/1384807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
