Thanks for this! One testing request if you can get to it.


http://gwt-code-reviews.appspot.com/1388804/diff/1/user/test/com/google/gwt/event/shared/ResettableEventBusTest.java
File user/test/com/google/gwt/event/shared/ResettableEventBusTest.java
(right):

http://gwt-code-reviews.appspot.com/1388804/diff/1/user/test/com/google/gwt/event/shared/ResettableEventBusTest.java#newcode94
user/test/com/google/gwt/event/shared/ResettableEventBusTest.java:94: //
eventBus2.registration.size() == 1 && subject.registration.size() == 0
I think it would be fine to add a package private method to allow the
test peek at the registration size, with javadoc "Visible for testing"

http://gwt-code-reviews.appspot.com/1388804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to