lgtm

http://gwt-code-reviews.appspot.com/1391802/diff/1/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
File dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java (right):

http://gwt-code-reviews.appspot.com/1391802/diff/1/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java#newcode34
dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java:34: public
DiskCacheToken(DiskCache diskCache, long token) {
maybe make this constructor default protected?  I assume its just for
unit testing, and deserializing the token is going to move the data to
the default disk instance anyway.

http://gwt-code-reviews.appspot.com/1391802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to