http://gwt-code-reviews.appspot.com/1385803/diff/2002/dev/core/src/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizer.java (right):
http://gwt-code-reviews.appspot.com/1385803/diff/2002/dev/core/src/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizer.java#newcode98 dev/core/src/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizer.java:98: private JType widenType(JType lhsType, JType rhsType) { On 2011/03/25 23:05:07, scottb wrote:
Please add that URL to a javadoc comment on this method.
Done. http://gwt-code-reviews.appspot.com/1385803/diff/1009/dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java (right): http://gwt-code-reviews.appspot.com/1385803/diff/1009/dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java#newcode28 dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java:28: private final class Result { On 2011/03/25 23:05:07, scottb wrote:
This is unused now, right? Since you're using the one in
OptimizerTestBase Done. http://gwt-code-reviews.appspot.com/1385803/diff/1009/dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java#newcode70 dev/core/test/com/google/gwt/dev/jjs/impl/PostOptimizationCompoundAssignmentNormalizerTest.java:70: // don't touch int op= in On 2011/03/25 23:05:07, scottb wrote:
typo, "int"
Done. http://gwt-code-reviews.appspot.com/1385803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
