LGTM

As long as you put a more description comment in the IE9 tabIndex impl


http://gwt-code-reviews.appspot.com/1383809/diff/4001/user/src/com/google/gwt/dom/client/DOMImplIE9.java
File user/src/com/google/gwt/dom/client/DOMImplIE9.java (right):

http://gwt-code-reviews.appspot.com/1383809/diff/4001/user/src/com/google/gwt/dom/client/DOMImplIE9.java#newcode67
user/src/com/google/gwt/dom/client/DOMImplIE9.java:67: return
elem.tabIndex < 65535 ? elem.tabIndex : -(elem.tabIndex % 65535) - 1;
The comment doesn't really explain what this is doing.  If IE9 returns
negative values for elem.tabIndex, wouldn't elem.tabIndex < 65535 always
be true?

http://gwt-code-reviews.appspot.com/1383809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to