http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java#newcode469 user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java:469: if ("true".equals(Shared.shouldSerializeFinalFields())) { On 2011/03/24 12:46:01, bobv wrote:
Use a enum instead of string comparisons.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java File user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java#newcode276 user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java:276: && !field.getDeclaringClass().toString().contains("java.lang.Enum"); On 2011/03/24 12:46:01, bobv wrote:
The use of toString() for any purpose other than debugging is an
anti-pattern.
!field.getDeclaringClass().equals(Enum.class)
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode2 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:2: * Copyright 2010 Google Inc. On 2011/03/24 12:46:01, bobv wrote:
Update copyright dates in new files.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode35 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:35: service.transfer_object(node, new AsyncCallback() { On 2011/03/24 12:46:01, bobv wrote:
Don't use a raw type for these callbacks.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java#newcode39 user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java:39: public void onSuccess(Object result) { On 2011/03/24 12:46:01, bobv wrote:
Verify the values of the unserialized final fields in the object.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java#newcode20 user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java:20: * TODO: document me. On 2011/03/24 12:46:01, bobv wrote:
Do so.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java#newcode46 user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java:46: FinalFieldsNode transfer_object(FinalFieldsNode node); On 2011/03/24 12:46:01, bobv wrote:
Use camel-cased method names.
Done. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
