Thanks for the review!
http://gwt-code-reviews.appspot.com/1396802/diff/2001/dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java File dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java (right): http://gwt-code-reviews.appspot.com/1396802/diff/2001/dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java#newcode44 dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java:44: public void testNewDir() throws IOException, UnableToCompleteException { On 2011/03/30 16:11:42, pdr wrote:
Would it be cleaner to wrap these exceptions and explicitly call fail(exception.getMessage())?
I did it this way because its easier than writing a try/catch block and you have to work even harder to capture the stacktrace. JUnit catches and reports any exceptions that escape the unit test. http://gwt-code-reviews.appspot.com/1396802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
