http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java File reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java (right):
http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java#newcode28 reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java:28: + " table via innerHTML, no widgets"); On 2011/03/31 21:45:18, rjrjr wrote:
might make it clearer that this is using a string builder on the
client (like
the current cell widget), not a big static string like the other one.
done
I also wonder if you should add another benchmark like this one that
uses
SafeHtmlBuilder rather than StringBuilder. Good chance to see if we're
paying an
additional tax for that.
I'll be running more benchmarks. Can I add that benchmark after submitting this change? http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java File reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java (right): http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java#newcode141 reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java:141: FlowPanel largeWidget = new FlowPanel(); On 2011/03/31 21:45:18, rjrjr wrote:
why create it if includeLargeWidget is false?
done And the reason was so I could remove it later without checking whether the checkbox was checked. http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java#newcode198 reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/WidgetCreation.java:198: root.remove(largeWidget); On 2011/03/31 21:45:18, rjrjr wrote:
you don't always add it, but you always remove it.
done But it was safe because we always created it, and #remove() exits early if the root isn't the parent of largeWidget. http://gwt-code-reviews.appspot.com/1394802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
