http://gwt-code-reviews.appspot.com/1405801/diff/1/tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java File tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java (right):
http://gwt-code-reviews.appspot.com/1405801/diff/1/tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java#newcode233 tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java:233: .getApiClass("test.apicontainer.OneMoreApiClass"); Quadruple spaces are pretty here, but push the code too far to the right. As far as I can tell, it breaks with Google's normal Java style. I would prefer 2 spaces. http://gwt-code-reviews.appspot.com/1405801/diff/1/tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java#newcode256 tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java:256: .size()); This is an example of where the builder pattern rules makes normal code ugly. This should be: assertEquals(1, oneMoreApiClass.getApiMembersBySet(methodNames, ApiClass.MethodType.METHOD).size()); http://gwt-code-reviews.appspot.com/1405801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
