http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java#newcode396
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java:396:
+ "dayPeriodContext[@type=\"format\"]/"
On 2011/04/06 15:33:49, zundel wrote:
I think it looks wrong to us because we're used to not indenting
before the
string concatenation when formatted on a second line. The unwritten
rule it
seems to consistently follow is that new statements get one indent
from the
parent of the statement, (2 spaces), line continuation gets 2 indents
from the
parent statement (4 spaces).
I disagree, but I won't fight it (mostly because it appears to be a
change in the Eclipse formatter that I didn't find a knob to control).
By that logic, every succeeding line with + should be indented further,
but it isn't (and would be very ugly if it did). It also represents a
change to the formatting we have been using for 4+ years.
I think there is an argument for indenting again when there is another
level of nesting, like:
foo(long,list,of,arguments,
bar(more,arguments,here,
and,here))
but that isn't what is happening here.
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
