http://gwt-code-reviews.appspot.com/1412801/diff/3003/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right):
http://gwt-code-reviews.appspot.com/1412801/diff/3003/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java#newcode490 dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java:490: cacheFile.delete(); On 2011/04/12 15:46:14, scottb wrote:
Is this actually going to work on Windows? You haven't closed fis
yet. Maybe
you could kill two birds with one stone by setting a boolean and
moving this
code after the finally block.
Done. I left the error message in the catch block because they are slightly different. http://gwt-code-reviews.appspot.com/1412801/diff/3003/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java#newcode491 dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java:491: logger.log(TreeLogger.TRACE, "Igorning and deleting cache log " On 2011/04/12 15:35:56, tobyr wrote:
Typo "Igorning"
Done. http://gwt-code-reviews.appspot.com/1412801/diff/3003/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java#newcode495 dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java:495: logger.log(TreeLogger.TRACE, "Igorning and deleting cache log " On 2011/04/12 15:35:56, tobyr wrote:
And here too. Would be nice if we had JDK 7's multi-catch blocks.
Yes it would. Done. http://gwt-code-reviews.appspot.com/1412801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
