http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java File user/src/com/google/gwt/media/client/Video.java (right):
http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java#newcode88 user/src/com/google/gwt/media/client/Video.java:88: return (VideoElement) getMediaElement(); On 2011/04/13 17:46:08, jlabanca wrote:
I liked cast() better than a cast if it works.
Done (curious, why? Does it save a cast check?) http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/canvas/client/CanvasTest.java File user/test/com/google/gwt/canvas/client/CanvasTest.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/canvas/client/CanvasTest.java#newcode41 user/test/com/google/gwt/canvas/client/CanvasTest.java:41: private native boolean isFirefox35OrLater() /*-{ On 2011/04/13 17:46:08, jlabanca wrote:
public, private, and protected methods appear out of order. Also, you
can make
these isXXX() checks static.
Done. http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/AudioTest.java File user/test/com/google/gwt/media/client/AudioTest.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/AudioTest.java#newcode84 user/test/com/google/gwt/media/client/AudioTest.java:84: public MediaBase getMedia() { On 2011/04/13 17:46:08, jlabanca wrote:
public method after protected method
Done. http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/MediaTest.java File user/test/com/google/gwt/media/client/MediaTest.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/MediaTest.java#newcode110 user/test/com/google/gwt/media/client/MediaTest.java:110: // wait an additional 1000ms, then check that the seek was successful On 2011/04/13 17:46:08, jlabanca wrote:
1000ms => 5000ms
Done. http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/VideoTest.java File user/test/com/google/gwt/media/client/VideoTest.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/test/com/google/gwt/media/client/VideoTest.java#newcode71 user/test/com/google/gwt/media/client/VideoTest.java:71: assertEquals(height + "px", video.getOffsetHeight()); On 2011/04/13 17:46:08, jlabanca wrote:
Does this pass? getOffsetHeight/Width() returns an int, so this test
should
always fail.
It worked better in my head. Fixed. http://gwt-code-reviews.appspot.com/1415801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
