Thanks for the review.

At this point I'm not even sure what advice I would give, so I'm going to
hold off on the "do not use" bit.

On Tue, Apr 19, 2011 at 3:03 PM, <b...@google.com> wrote:

> LGTM.
>
>
>
> http://gwt-code-reviews.appspot.com/1425804/diff/1/user/src/com/google/gwt/event/shared/EventBus.java
> File user/src/com/google/gwt/event/shared/EventBus.java (right):
>
>
> http://gwt-code-reviews.appspot.com/1425804/diff/1/user/src/com/google/gwt/event/shared/EventBus.java#newcode28
> user/src/com/google/gwt/event/shared/EventBus.java:28: public <H>
> com.google.web.bindery.event.shared.HandlerRegistration
> addHandler(Event.Type<H> type, H handler) {
> Should the HandlerRegistration in this package have some kind of "do not
> use for new code" warning placed on its javadoc?
>
> Is there a pattern for "soft" deprecation where we don't want to cause
> deprecation warning spam, but don't want to encourage new uses of the
> type?  Would some kind of empty "NewUsesAreBadIdea" tag interface help
> with this?
>
>
> http://gwt-code-reviews.appspot.com/1425804/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to