Reviewers: jbrosenberg, tobyr,
Description:
Another case identified where spam reduction reduced too much and didn't
print a relavent
error message.
Please review this at http://gwt-code-reviews.appspot.com/1420805/
Affected files:
M user/src/com/google/gwt/junit/JUnitShell.java
Index: user/src/com/google/gwt/junit/JUnitShell.java
===================================================================
--- user/src/com/google/gwt/junit/JUnitShell.java (revision 10033)
+++ user/src/com/google/gwt/junit/JUnitShell.java (working copy)
@@ -735,14 +735,10 @@
if (unit == null) {
errMsg = "The test class '" + typeName + "' was not found in
module '"
+ moduleName + "'; no compilation unit for that type was seen";
- } else if (unit.isError()) {
+ } else {
CompilationProblemReporter.logMissingTypeErrorWithHints(logger,
typeName, compilationState);
errMsg = "The test class '" + typeName
+ "' had compile errors; check log for details";
- } else {
- errMsg = "Unexpected error: the test class '"
- + typeName
- + "' appears to be valid, but no corresponding type was found in
TypeOracle; please contact GWT support";
}
return new JUnitFatalLaunchException(errMsg);
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
