If Rodrigo has time to add Editors, its likely to get done sooner than I
can get to it.

As far as ClientFactory, should we consider using gin?

On 2011/04/20 21:51:42, rjrjr wrote:
LGTM

Sorry for the belated review. This is a great sample, we'll get a lot
of mileage
out of it.

My only complaint is that the clientFactory has too many getters and
is passed
around too much. I'll take a crack at fixing that myself.

The app also doesn't use the Editor framework like it should. John L
is supposed
to be on the hook for that, but I wonder if Rodrigo should go ahead
and do it
instead, just as an excuse to get familiar with editors.



http://gwt-code-reviews.appspot.com/1427803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to