Nick, could you take a look at this too? In particular see the bottom of http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
On Thu, Apr 21, 2011 at 6:57 AM, <b...@google.com> wrote: > Reviewers: rjrjr, > > Message: > Request requested. > > > > http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java > File > > user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java > (right): > > > http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java#newcode526 > > user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java:526: > // Construct an ID that represents domainObject > Interesting change starts here. > > Description: > Switch RequestFactory to use the real ConstraintViolation instead of the > hacky Violation interface. > Deprecate Violation and Receiver.onViolation(). > Patch by: bobv > Review by: rjrjr > > > Please review this at http://gwt-code-reviews.appspot.com/1422809/ > > Affected files: > M > samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java > M > user/src/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryEditorDriver.java > M > user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java > M > user/src/com/google/web/bindery/requestfactory/gwt/client/testing/MockRequestFactoryEditorDriver.java > M > user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java > M > user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java > M user/src/com/google/web/bindery/requestfactory/shared/Receiver.java > M user/src/com/google/web/bindery/requestfactory/shared/Violation.java > M > user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java > M > user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java > M > user/src/com/google/web/bindery/requestfactory/shared/messages/ViolationMessage.java > M user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java > M > user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java > M > user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java > M > user/test/com/google/web/bindery/requestfactory/gwt/client/ui/EditorTest.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
