r10052
http://gwt-code-reviews.appspot.com/1423805/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/1423805/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode103 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:103: * an invocation argument. On 2011/04/21 19:36:38, rjrjr wrote:
Don't they also land here via create?
Done. http://gwt-code-reviews.appspot.com/1423805/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1423805/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode239 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:239: assertSame(foo2, c3.edit(foo2)); On 2011/04/21 19:36:38, rjrjr wrote:
should you test a create from c3 as well? I could imagine there being
upstream /
downstream issues for non-neighbors.
Done. http://gwt-code-reviews.appspot.com/1423805/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode243 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:243: fail("Should have thrown IllegalStateException"); On 2011/04/21 19:36:38, rjrjr wrote:
because c3 has already been appended?
Done. http://gwt-code-reviews.appspot.com/1423805/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode262 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:262: c3.fire(new Receiver<Void>() { On 2011/04/21 19:36:38, rjrjr wrote:
what happens if you fire c1 or c2 instead? Should that be tested?
Done. http://gwt-code-reviews.appspot.com/1423805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
