The problem is that the combination LazyPanel + "provided = true" can be used to put LazyPanel widgets in templates. There were 2 possible fixes:
1. check whether the LazyPanel has inner widgets or not and then show the proper message. 2. let things as is and register the new LazyPanel parser only if the flag is enabled Due to the urgency of things I went with #2. On Mon, Apr 25, 2011 at 3:42 PM, Ray Ryan <rj...@google.com> wrote: > You sure? I kind of liked how you changed this to always run, and explain > to the user what flag to set to make it go. > > > On Fri, Apr 22, 2011 at 5:43 PM, <her...@google.com> wrote: > >> Reviewers: rjrjr, jat, >> >> Description: >> LazyPanel parser should be enabled only if useLazyWidgetBuilders is >> enabled. >> >> >> Please review this at http://gwt-code-reviews.appspot.com/1423806/ >> >> Affected files: >> M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java >> >> >> Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java >> =================================================================== >> --- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision >> 10054) >> +++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working >> copy) >> @@ -1144,7 +1144,9 @@ >> addWidgetParser("HasAlignment"); >> addWidgetParser("DateLabel"); >> addWidgetParser("NumberLabel"); >> - addWidgetParser("LazyPanel"); >> + if (useLazyWidgetBuilders) { >> + addWidgetParser("LazyPanel"); >> + } >> } >> >> /** >> >> >> > -- --Hermes Freitas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
