Revision: 10095
Author: gwt.mirror...@gmail.com
Date: Thu Apr 28 03:49:08 2011
Log: Making ui:style builders always called in the Widgets ctor. Also
add a
final clause in field builders.
Review at http://gwt-code-reviews.appspot.com/1422814
http://code.google.com/p/google-web-toolkit/source/detail?r=10095
Modified:
/trunk/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
/trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriterOfGeneratedCssResource.java
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
Wed Apr 27 13:54:04 2011
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
Thu Apr 28 03:49:08 2011
@@ -227,7 +227,7 @@
if (getterCount > 1) {
w.write("%s = %s;", name, initializer);
} else {
- w.write("%s %s = %s;", getQualifiedSourceName(), name, initializer);
+ w.write("final %s %s = %s;", getQualifiedSourceName(), name,
initializer);
}
w.write("// Setup section.");
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriterOfGeneratedCssResource.java
Fri Nov 20 13:09:39 2009
+++
/trunk/user/src/com/google/gwt/uibinder/rebind/FieldWriterOfGeneratedCssResource.java
Thu Apr 28 03:49:08 2011
@@ -20,6 +20,7 @@
import com.google.gwt.core.ext.typeinfo.JType;
import com.google.gwt.uibinder.attributeparsers.CssNameConverter;
import com.google.gwt.uibinder.rebind.model.ImplicitCssResource;
+import com.google.gwt.uibinder.rebind.model.OwnerField;
import java.util.Set;
@@ -69,4 +70,11 @@
}
return super.getReturnType(path, logger);
}
-}
+
+ @Override
+ public void writeFieldBuilder(IndentedWriter w,
+ int getterCount, OwnerField ownerField) throws
UnableToCompleteException {
+ w.write("%s; // generated css resource must be always created.
Precedence: %s",
+ FieldManager.getFieldBuilder(getName()), getBuildPrecedence());
+ }
+}
=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java Wed
Apr 27 13:54:04 2011
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java Thu
Apr 28 03:49:08 2011
@@ -1080,7 +1080,9 @@
fieldManager.registerFieldOfGeneratedType(
oracle.findType(ClientBundle.class.getName()),
bundleClass.getPackageName(), bundleClass.getClassName(),
- bundleClass.getFieldName());
+ bundleClass.getFieldName())
+ .setBuildPrecedence(Integer.MAX_VALUE); // must be the first thing
built.
+
// Allow GWT.create() to init the field, the default behavior
String rootField = new UiBinderParser(this, messages, fieldManager,
oracle,
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors