Running ant clean dist-dev test, this appears to break the i18n suite under html unit.
Testcase: testMessageDateTime took 0.15 sec FAILED Remote test failed at 172.31.131.172 / Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.19) Gecko/2010031422 Firefox/3.0.19 expected=It is Feb 15, 2010 actual=It is 2010 Feb 15 junit.framework.AssertionFailedError: Remote test failed at 172.31.131.172 / Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.19) Gecko/2010031422 Firefox/3.0.19 expected=It is Feb 15, 2010 actual=It is 2010 Feb 15 On Tue, May 3, 2011 at 9:42 AM, Ray Ryan <[email protected]> wrote: > LGTM > > Thanks, will submit. > > > On Tue, May 3, 2011 at 2:40 AM, <[email protected]> wrote: > >> Reviewers: rjrjr, bobv, >> >> Description: >> Force locale to en_US for "user" unit tests >> >> Force locale to en_US for "user" unit tests, otherwise validation tests >> fail (use hard-coded checks on locale-dependent messages) >> >> Please review this at http://gwt-code-reviews.appspot.com/1430801/ >> >> Affected files: >> M user/build.xml >> >> >> Index: user/build.xml >> diff --git a/user/build.xml b/user/build.xml >> index >> 4f6286fd2e654d9b63ad55bc393807b23954c084..e7696fff725e9e66ee2072d7975173bbc420f178 >> 100755 >> --- a/user/build.xml >> +++ b/user/build.xml >> @@ -2,7 +2,8 @@ >> <property name="gwt.root" location=".." /> >> <property name="project.tail" value="user" /> >> <property name="test.args" value="-ea" /> >> - <property name="test.jvmargs" value="-ea" /> >> + <!-- Bean validation and RequestFactory tests use hard-coded checks on >> locale-dependent messages --> >> + <property name="test.jvmargs" value="-ea -Duser.language=en >> -Duser.region=US" /> >> >> <!-- support old variables names --> >> <condition property="gwt.hosts.web.remote" >> value="${gwt.remote.browsers}"> >> @@ -763,7 +764,7 @@ >> excludes="${gwt.tck.testcase.dev.excludes}" /> >> <gwt.junit test.name="test.dev.htmlunit" >> test.args="${test.args} -standardsMode " >> - test.jvmargs="-ea >> -Dcom.google.gwt.sample.validationtck.util.Failing.include=true >> -Dcom.google.gwt.sample.validationtck.util.NonTckTest.exclude=true" >> + test.jvmargs="${test.jvmargs} >> -Dcom.google.gwt.sample.validationtck.util.Failing.include=true >> -Dcom.google.gwt.sample.validationtck.util.NonTckTest.exclude=true" >> test.out="${junit.out}/tck-dev-htmlunit" >> test.cases="tck.dev.htmlunit.tests" >> haltonfailure="false" >> >> >> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
