I have a few questions about appcache and linkers, but it looks pretty
good.


http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
File dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
(right):

http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode49
dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:49: *
Add <p> before each paragraph

http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode55
dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:55: *
and overrides {@code otherCAchedFiles()}, and use it as a linker
instead:
/r/otherCAchedFiles/otherCachedFiles

You might mention that wildcards, such as /audio/*, will work (I think
thats true).

http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode68
dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:68:
public class SimpleAppCacheLinker extends AbstractLinker {
I didn't see a rule in a gwt.xml file.  Do linkers run automatically?

If so, can this linker be disabled? I'm not sure everyone will want to
use appcache.

http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java#newcode102
dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java:102:
protected String[] otherCachedFiles() {
This is fine for now, but it would be nice if users could specify other
cached files in a gwt.xml or appcache.manifest file instead of
overriding this class.

http://gwt-code-reviews.appspot.com/1428811/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
File
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
(right):

http://gwt-code-reviews.appspot.com/1428811/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode37
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:37:
"/audio/error.wav"
also add:
video/tutorial.mp4
video/tutorial.ogv

http://gwt-code-reviews.appspot.com/1428811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to